Update lakectl abuse to use set/link physical address #7743
Conversation
N-o-Z
added
bug
E2E Test Results - DynamoDB Local - Local Block Adapter |
N-o-Z
force-pushed
the
task/lakectl-abuse-use-link-physical-addr-7740
branch
from
7b785f0
to
5ae1894
Compare
N-o-Z
changed the title
| } | ||
| }) | ||
| }, | ||
|
|
There was a problem hiding this comment.
Can you add a simple comment about the fact that you're linking without uploading to the object store?
esti/lakectl_test.go
Outdated
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.Cmd, func(t *testing.T) { | ||
| RunCmdAndVerifyContainsText(t, Lakectl()+" abuse "+tt.Cmd+" lakefs://"+repoName+"/"+mainBranch+" --amount "+strconv.Itoa(tt.Amount)+" "+tt.AdditionalArgs, false, "errors: 0", map[string]string{}) |
There was a problem hiding this comment.
This string may be easier to read if generated from a template or using fmt.Sprintf.
| const totalObjects = 5 | ||
| for i := 0; i < totalObjects; i++ { | ||
| vars["FILE_PATH"] = fmt.Sprintf("data/ro/ro_1k.%d", i) | ||
| fromFile = fromFile + vars["FILE_PATH"] + "\n" |
There was a problem hiding this comment.
I don't understand this loop at all.
- Each iteration appends an entire new line to
fromFile! How does that run? - What writes these 5 objects? Do they need to be added to the repo?
There was a problem hiding this comment.
- The commands read a file from the provided param and reads line by lines keys from the file
- What writes these 5 objects is line 876 (now 875), we use an existing test file in our repo for the physical object
There was a problem hiding this comment.
OK, thanks! The code is a bit confusing. I would probably find it easier to read if you wrote the filename to the abuse-read file immediately, rather than build a string in-memory and then write it on l. 879.
There was a problem hiding this comment.
I agree but this requires us to handle stdin input in the lakectl tests... 😬
| const totalObjects = 5 | ||
| for i := 0; i < totalObjects; i++ { | ||
| vars["FILE_PATH"] = fmt.Sprintf("data/ro/ro_1k.%d", i) | ||
| fromFile = fromFile + vars["FILE_PATH"] + "\n" |
There was a problem hiding this comment.
OK, thanks! The code is a bit confusing. I would probably find it easier to read if you wrote the filename to the abuse-read file immediately, rather than build a string in-memory and then write it on l. 879.
* Update lakectl abuse to use set/link physical address * CR Fixes * Fix test
Closes #7740
Change Description
Background
Modify lakectl abuse random-write so that it will reflect the behavior of lakeFS
Bug Fix
Added some bug fixes and tests to the abuse commands
Testing Details
Added esti tests