Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle KV slow down error #7744

Merged
merged 1 commit into from
May 8, 2024
Merged

Handle KV slow down error #7744

merged 1 commit into from
May 8, 2024

Conversation

eladlachmi
Copy link
Contributor

Closes #7742

This PR corrects the handling of KV throttling/slow-down errors. Instead of returning generic HTTP status 500, it returns HTTP status 503. This will allow client implementations to detect this error, slow down, and retry. This behavior is aligned with that in the S3 gateway.
Also, it returns a succinct, informative, and user-readable status text to clients.

@eladlachmi eladlachmi added bug Something isn't working area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog labels May 8, 2024
@eladlachmi eladlachmi requested a review from guy-har May 8, 2024 11:37
@eladlachmi eladlachmi self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link
Contributor

@guy-har guy-har left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eladlachmi eladlachmi merged commit 2f859e2 into master May 8, 2024
41 checks passed
@eladlachmi eladlachmi deleted the 7742-kv-slow-down-error branch May 8, 2024 14:22
emulatorchen pushed a commit to emulatorchen/lakeFS that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: KV Throttling Errors Handled Incorrectly
2 participants