Make the number of DynamoDB connections configurable #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
added
the
include-changelog
|
No linked issues found. Please add the corresponding issues in the pull request description. |
|
♻️ PR Preview 4e95866 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
guy-har
approved these changes
May 12, 2024
| @@ -57,6 +57,8 @@ This reference uses `.` to denote the nesting of values. | |||
| + **Note:** `endpoint` `aws_region` `aws_access_key_id` `aws_secret_access_key` are not required and used mainly for experimental purposes when working with DynamoDB with different AWS credentials. | |||
| {: .note } | |||
| + `database.dynamodb.health_check_interval` `(duration : 0s)` - Interval to run health check for the DynamoDB instance (won't run if equal to 0). | |||
| + `database.dynamodb.max_attempts` `(int : 10)` - The maximum number of attempts to perform on a DynamoDB request | |||
| + `database.dynamodb.max_connections` `(int : 0)` - The maximum number of connections to DynamoDB. 0 means no limit. | |||
There was a problem hiding this comment.
Are we sure we want to change the default to unlimited?
There was a problem hiding this comment.
Yes, I don't think we should have a default limitation on one of the system's bottlenecks: the kv store.
There was a problem hiding this comment.
Unless I'm missing something
arielshaqed
changed the title
emulatorchen
pushed a commit
to emulatorchen/lakeFS
that referenced
this pull request
May 27, 2024
* Change MaxConnectionsPerHost DDB * Change config param name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow installations to adjust their DDB usage to their loads.