Make MaxBatchDelay configurable #7774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaiad200
added
the
include-changelog
|
♻️ PR Preview a453c81 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
E2E Test Results - DynamoDB Local - Local Block Adapter |
arielshaqed
approved these changes
May 18, 2024
There was a problem hiding this comment.
LGTM, thanks!
This is certainly an improvement. However the fact that we state that different values are suitable to different workloads means that this is not a good value to put in configuration! An installation will have different workloads, which value do I pick?
It does make sense for now, and it certainly does make sense for different KVs.
Ideally we would ultimately feed back information about the batch load. Not even sure which numbers I would want to collect to be able to generate the model for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7773