Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return installation ID as part of health check response #964

Merged
merged 2 commits into from Nov 26, 2020

Conversation

nopcoder
Copy link
Contributor

@nopcoder nopcoder commented Nov 25, 2020

Provide installation ID as part of health route

@nopcoder nopcoder requested review from johnnyaug and removed request for johnnyaug November 25, 2020 18:30
@nopcoder nopcoder self-assigned this Nov 25, 2020
@nopcoder nopcoder added this to In progress in lakeFS via automation Nov 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #964 (f4216c2) into master (d0b734b) will increase coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   44.79%   44.89%   +0.10%     
==========================================
  Files         142      142              
  Lines       11448    11449       +1     
==========================================
+ Hits         5128     5140      +12     
+ Misses       5680     5671       -9     
+ Partials      640      638       -2     
Impacted Files Coverage Δ
httputil/endpoints.go 0.00% <0.00%> (ø)
catalog/mvcc/cataloger_create_branch.go 84.90% <0.00%> (-3.78%) ⬇️
stats/collector.go 62.06% <0.00%> (+2.29%) ⬆️
catalog/mvcc/cataloger_create_entry.go 100.00% <0.00%> (+5.26%) ⬆️
catalog/mvcc/cataloger_create_repository.go 66.66% <0.00%> (+7.40%) ⬆️
config/logger.go 75.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b734b...f4216c2. Read the comment docs.

@nopcoder nopcoder requested review from ozkatz and removed request for johnnyaug November 26, 2020 08:39
lakeFS automation moved this from In progress to Review in progress Nov 26, 2020
@nopcoder nopcoder merged commit 04e6499 into master Nov 26, 2020
lakeFS automation moved this from Review in progress to Done Nov 26, 2020
@nopcoder nopcoder deleted the feature/installation-id branch November 26, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
lakeFS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants