Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add installation id after init #983

Merged
merged 7 commits into from
Dec 1, 2020

Conversation

johnnyaug
Copy link
Contributor

Closes #982

@johnnyaug johnnyaug requested a review from ozkatz December 1, 2020 11:31
Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@codecov-io
Copy link

Codecov Report

Merging #983 (cd0f571) into master (4f89db9) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   44.58%   44.57%   -0.01%     
==========================================
  Files         142      142              
  Lines       11547    11553       +6     
==========================================
+ Hits         5148     5150       +2     
- Misses       5757     5759       +2     
- Partials      642      644       +2     
Impacted Files Coverage Δ
stats/collector.go 61.36% <0.00%> (-0.71%) ⬇️
api/api_controller.go 37.91% <50.00%> (+<0.01%) ⬆️
catalog/mvcc/cataloger_create_repository.go 59.25% <0.00%> (-3.71%) ⬇️
catalog/mvcc/cataloger_create_entry.go 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f89db9...cd0f571. Read the comment docs.

@johnnyaug johnnyaug merged commit c152e2c into master Dec 1, 2020
@johnnyaug johnnyaug deleted the bugfix/add_installation_id_after_init branch December 1, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

init event sent without installation id for init through API
3 participants