Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation #14

Closed
denpatin opened this issue Feb 24, 2017 · 18 comments
Closed

Russian translation #14

denpatin opened this issue Feb 24, 2017 · 18 comments

Comments

@denpatin
Copy link
Contributor

Hi @treffynnon,

thank you for your great work! I do admire this style guide.

I'd like to perform a translation of it into Russian so that these well-favored rules become more available and googleable among Russian SQL developers. Do I get it right that I need to translate only the file sqlstyle.guide.md inside the _includes folder, don't I?

Best,
Den

@treffynnon
Copy link
Owner

treffynnon commented Feb 24, 2017 via email

@treffynnon
Copy link
Owner

@denpatin I am closing this issue due to inactivity. If you would like to do the translation then please re-open the ticket.

@denpatin
Copy link
Contributor Author

denpatin commented Mar 21, 2017

@treffynnon It's especially nice that you've closed the ticket considering that I have even two local branches for Russian (the translation to which is almost 1/3 ready; it's a tricky task to make Russian sound adequately in the world of technical parlance) and German languages (the translation to which is 100% ready, but just needed a technical proof (re-)reading from my side) :) However OK, I'll reopen the issue and open a new one (for German) when I'm entirely done (supposedly by the end of the week).

@treffynnon
Copy link
Owner

treffynnon commented Mar 21, 2017 via email

@denpatin
Copy link
Contributor Author

I generally close all tickets on my projects after around a month of no updates to the ticket. I like to keep it inbox zero.

OK!

Auf Deutsch - toll!

I ain't the translator, but I can handle the technical part much better than the translator, which is just an economist yet a native speaker 😺

Thanks for reopening. For some reason I couldn't see any Reopen an issue button...

@treffynnon treffynnon reopened this Mar 21, 2017
@denpatin
Copy link
Contributor Author

@treffynnon Small update.

I've finished with Russian translation, and I need just to transfer it into Markdown—will be done in one-two days.

Concerning the German translation, I'm still proof reading it as the translator's language is far from the technical world. It will be also finished in a couple of days.

Btw, should I put the links to the both translations in the header _includes/head.html and footer _includes/foot.html?

@treffynnon
Copy link
Owner

Nice! Thanks for the update.

should I put the links to the both translations in the header _includes/head.html and footer _includes/foot.html?

Yep, those are the two places to put the links.

@denpatin
Copy link
Contributor Author

Hi @treffynnon,
I'm really sorry that I haven't PR'ed the two translations 😿
I have overestimated the presence of free time of mine, oh. So still need some more time... But it definitely will be finished as only small things remain.

@treffynnon
Copy link
Owner

treffynnon commented Mar 30, 2017 via email

@denpatin
Copy link
Contributor Author

Hi @treffynnon, still experiencing some difficulties with time while keeping on gradually soldiering on :) Soon there'll be updates.

@treffynnon
Copy link
Owner

treffynnon commented Apr 18, 2017 via email

@denpatin
Copy link
Contributor Author

@treffynnon Finally I was able to muster sufficient strength to finalize the Russian translation. I haven't made it literal, thus I've changed some things, of course leaving the core idea untouched. Just language related things so as to make the translation sound naturally. And I've added a couple of line to some technical files like footer and header; hope it's correct :)

@denpatin
Copy link
Contributor Author

@treffynnon
One thing to be clarified. In all the present translations, while serving them, I can click on any menu item and thus navigate to any corresponding paragraph. In the URL there's either #columns (for English), ja/#列 (for Japanese), etc. However for Russian it's for some reason ru/#section-7. I've looked at the source code for Japanese and Chinese and have found nothing that is needed additionally, so these anchors are generated automatically. But not for Russian... Some troubles with the Cyrillic alphabet? Weird because Japanese alphabet is much more difficult and extensive regarding Unicode. Any ideas?

@treffynnon
Copy link
Owner

Thank you for the pull request. I have had a quick look, but I'll take a closer look soon. Looks good so far though.

In the URL there's either #columns (for English), ja/#列 (for Japanese), etc. However for Russian it's for some reason ru/#section-7. I've looked at the source code for Japanese and Chinese and have found nothing that is needed additionally, so these anchors are generated automatically. But not for Russian... Some troubles with the Cyrillic alphabet?

I don't know about this. I think the anchors are generated by Jekyll or it might be Kramdown. I'll take a quick look to see if I can see why or if there are open issues on those projects. It might have to be something we live with though, unfortunately.

@denpatin
Copy link
Contributor Author

denpatin commented May 1, 2017

@treffynnon
Ok, looking forward to your feedback.

Regarding these anchors, I could suggest to, say, use hardcoded <span>'s, like it's done for the Reserved keywords section. Maybe it could make a sense, but still it'll slightly dirty the original Markdown layout...

@treffynnon
Copy link
Owner

Looks like Kramdown has an option transliterated_header_ids. I think it would change the existing anchors in the other languages too of course so any links in the wild to them would be broken - I've not had a chance to test yet.

@treffynnon
Copy link
Owner

treffynnon commented May 2, 2017

Thank you very much for the Russian translation of the guide. I have now merged it in with only a couple of very minor changes - you can see my commits: https://github.com/treffynnon/sqlstyle.guide/commits/gh-pages

Also I am not sure why - perhaps removing the wrapping div - but we now have Cyrillic anchors/headers/table of contents links from what I can see. The wrapping div is no longer required in translations because the lang="ru" attribute is set in _layouts/default.html on the <main> tag.

A sample link: http://www.sqlstyle.guide/ru/#Чего-следует-избегать

@denpatin
Copy link
Contributor Author

denpatin commented May 2, 2017

@treffynnon Great that anchors are working now! I've inserted this <div> more than a month ago so yes, since then something could have changed.

And thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants