Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.12 no longer includes distutils #239

Merged
merged 1 commit into from Nov 13, 2023
Merged

Python 3.12 no longer includes distutils #239

merged 1 commit into from Nov 13, 2023

Conversation

ryansb
Copy link
Contributor

@ryansb ryansb commented Oct 17, 2023

Replace the use of distutils find_executable with the standard library shutil.which

@ryansb
Python 3.12 no longer includes distutils
7a74b09 
Replace the use of distutils `find_executable` with the standard library
`shutil.which`
@mtskillman mtskillman self-assigned this Oct 18, 2023
@mtskillman mtskillman self-requested a review October 18, 2023 14:42
@wesleykirkland
Copy link

Hi @mtskillman Can we get this PR reviewed please? We use awsume a lot internally and would like to use it without forcing Python 3.11.

mtskillman
mtskillman approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@mtskillman mtskillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mtskillman mtskillman merged commit a8e0f83 into trek10inc:master Nov 13, 2023
5 checks passed
@mtskillman mtskillman mentioned this pull request Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtskillman mtskillman mtskillman approved these changes

Assignees

@mtskillman mtskillman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryansb @wesleykirkland @mtskillman