Skip to content
This repository has been archived by the owner on Nov 6, 2021. It is now read-only.

Add the option to add HTTP PROXY when communicating with AWS #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

williamsia
Copy link

This is to address network connectivity issue when communicating with AWS when working behind corporate proxy.

@azurelogic
Copy link
Contributor

Hey @williamsia, Thanks for the PR! I get what you're after here, but let me take this back to the drawing board and see what I can do in terms of offering something more flexible. I'm sure others may need access to the AWS.config object for other uses, and I don't think it is sustainable to do this kind of thing for every provider long term. I'm thinking of another client method that lets you send a "configuration callback" to be executed before the provider is retrieved, and the AWS.config would be passed in as an argument for the consumer to tweak as needed. Thoughts?

@williamsia
Copy link
Author

Hi @azurelogic thanks for the quick reply. Maybe we should have just the provider specified by the serverless framework itself, https://github.com/serverless/serverless/blob/master/lib/plugins/aws/provider/awsProvider.js#L114
so we don't have to reinvent the wheel. We just piggy backing all the AWS options set back the serverless framework itself.

And just uses the provider the way "sls invoke" uses it as specified in https://github.com/serverless/serverless/blob/master/lib/plugins/aws/invoke/index.js#L82

But that means more changes on the code. I don't mind doing some of the work if you agree with this approach, either way happy to follow your lead mate.

Cheers

snyk-test and others added 2 commits July 11, 2019 08:32
…7f35d82e6bbc76

[Snyk] Fix for 1 vulnerable dependencies
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants