fix longestCommonSubstring() to handle unicode characters (#129) #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 134 134
Lines 2486 2487 +1
Branches 416 416
=====================================
+ Hits 2486 2487 +1
Continue to review full report at Codecov.
|
|
before: After: |
|
@daddou-ma thank you for the fix! |
|
@trekhleb You're welcome ^^ |
harshes53
pushed a commit
to harshes53/javascript-algorithms
that referenced
this pull request
Dec 6, 2018
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A have fixed the
longestCommonSubstringto handle unicode characters by spliting the string into an array of one character strings.