Update android arch lifecycle version #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this fails due to lint issues. Could you look into that? Also, I thought fixing #245 would require some source code changes (inheritance-wise). |
|
According to this lifecycle component issue, I think there is no code changes needed. And also I reported about the I will update my PR to fix build failure. |
|
Thanks so much for the work! |
tir38
added a commit
to tir38/android-buddybuild
that referenced
this pull request
Dec 13, 2017
Our app was crashing after updating to latest Android Architecture libraries. We need to update RxLifecycle to match these changes. Read more here: trello/RxLifecycle#245 trello/RxLifecycle#249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
com.trello.lifecycle2.android.lifecycle.AndroidLifecycle_LifecycleProviderto implementsandroid.arch.lifecycle.GeneratedAdapter.Fixes #245