Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example sketch #2

Merged
merged 1 commit into from May 11, 2018
Merged

Add an example sketch #2

merged 1 commit into from May 11, 2018

Conversation

algernon
Copy link
Collaborator

No description provided.

@tremby
Copy link
Owner

tremby commented May 11, 2018

I won't merge the gitignore file -- those files you want to ignore are specific to your environment (I don't have them) and so you should have them in a global gitignore file such as ~/.config/git/ignore.

As for the rest, do you not think the readme is clear enough?

@algernon
Copy link
Collaborator Author

I'll drop the .gitignore then - though output/ is generated by the Makefile when building the example, so it might be worth keeping. But I'll let you add it if you choose to do so.

As for the rest, do you not think the readme is clear enough?

It is, but having an example gives me two things the README does not:

  • An example sketch in the Arduino IDE
  • A sketch I can compile and test if the plugin still works after making changes in Kaleidoscope core.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
@tremby
Copy link
Owner

tremby commented May 11, 2018

OK. Thanks!

@tremby tremby merged commit 8e904d2 into tremby:master May 11, 2018
@algernon algernon deleted the f/example branch May 11, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants