Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-merge dependabot feature - rebase feature #1596

Merged
merged 1 commit into from
May 2, 2022

Conversation

PrimalPimmy
Copy link
Contributor

@PrimalPimmy PrimalPimmy commented May 2, 2022

Signed-off-by: PrimalPimmy Prashant20.pm@gmail.com

Pull request

Description

Added option to rebase during automerge

Related

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

Signed-off-by: PrimalPimmy <Prashant20.pm@gmail.com>
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1596 (949e75f) into main (c8bdda3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1596   +/-   ##
=======================================
  Coverage   85.45%   85.46%           
=======================================
  Files         230      230           
  Lines       45996    45996           
=======================================
+ Hits        39306    39309    +3     
+ Misses       6690     6687    -3     
Flag Coverage Δ
unittests 85.46% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pipeline.rs 76.38% <0.00%> (-0.28%) ⬇️
src/connectors/sink.rs 82.75% <0.00%> (-0.21%) ⬇️
src/connectors.rs 85.89% <0.00%> (-0.16%) ⬇️
src/connectors/source.rs 80.48% <0.00%> (-0.12%) ⬇️
tremor-value/src/value.rs 98.99% <0.00%> (+0.09%) ⬆️
src/system/flow_supervisor.rs 85.71% <0.00%> (+0.84%) ⬆️
src/connectors/source/channel_source.rs 80.00% <0.00%> (+1.66%) ⬆️
src/version.rs 87.50% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8bdda3...949e75f. Read the comment docs.

@Licenser Licenser merged commit 0e7fa6c into tremor-rs:main May 2, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2258836893

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.007%) to 85.462%

Files with Coverage Reduction New Missed Lines %
src/connectors.rs 1 85.89%
src/connectors/sink.rs 1 82.75%
src/connectors/source.rs 1 80.48%
src/pipeline.rs 1 76.39%
Totals Coverage Status
Change from base Build 2258684224: 0.007%
Covered Lines: 39309
Relevant Lines: 45996

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants