Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eqc CI setup #700

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Fix eqc CI setup #700

merged 3 commits into from
Jan 19, 2021

Conversation

mfelsche
Copy link
Member

Pull request

Description

  • Make eqc fail CI when tests fail
  • Fix eqc suite

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

@coveralls
Copy link
Collaborator

coveralls commented Jan 15, 2021

Coverage Status

Coverage remained the same at 80.788% when pulling 5200817 on eqc-ci into cf61402 on main.

Matthias Wahl added 2 commits January 18, 2021 14:44
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
Prepared = tremor_http:decode(list_to_binary(jsg_json:encode(Offramp))),
offramp_add_valid_config(Prepared).

%% add a valid config - this is to cumbersome to express in openapi.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps nothing for today but it'd be nice but we should probably ticket that we make generators for configs.

Licenser
Licenser previously approved these changes Jan 18, 2021
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

Signed-off-by: Matthias Wahl <mwahl@wayfair.com>
@mfelsche mfelsche marked this pull request as ready for review January 18, 2021 23:25
@Licenser Licenser merged commit 63e9bd6 into main Jan 19, 2021
@Licenser Licenser deleted the eqc-ci branch January 19, 2021 09:20
This was referenced Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants