Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate missing artifacts #714

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Investigate missing artifacts #714

merged 1 commit into from
Jan 25, 2021

Conversation

Licenser
Copy link
Member

Pull request

Description

Trying to get the builds uploading

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes or other observable changes in behavior

@Licenser Licenser marked this pull request as draft January 25, 2021 16:43
@coveralls
Copy link
Collaborator

coveralls commented Jan 25, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 80.845% when pulling a880ff4 on pkg-try-2 into 34a840b on main.

@Licenser
Investigate missing artifacts
a880ff4 
Signed-off-by: Heinz N. Gies <heinz@licenser.net>
@Licenser Licenser marked this pull request as ready for review January 25, 2021 17:24
darach
darach approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Licenser Licenser merged commit a6906aa into main Jan 25, 2021
@Licenser Licenser deleted the pkg-try-2 branch January 25, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach darach approved these changes

@anupdhml anupdhml Awaiting requested review from anupdhml

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Licenser @coveralls @darach