-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: postcss upgrade for storybook #173
Merged
mitrotasios
merged 3 commits into
tremorlabs:main
from
jelleag:bug/postcss_upgrade_for_storybook
Nov 8, 2022
Merged
build: postcss upgrade for storybook #173
mitrotasios
merged 3 commits into
tremorlabs:main
from
jelleag:bug/postcss_upgrade_for_storybook
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitrotasios
changed the title
fix/postcss upgrade for storybook
test: postcss upgrade for storybook
Nov 8, 2022
Thanks for the PR! |
mitrotasios
approved these changes
Nov 8, 2022
mitrotasios
changed the title
test: postcss upgrade for storybook
build: postcss upgrade for storybook
Nov 8, 2022
mitrotasios
added a commit
that referenced
this pull request
Nov 8, 2022
This reverts commit 6691425.
mitrotasios
added a commit
that referenced
this pull request
Nov 8, 2022
🎉 This PR is included in version 1.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
The release ci pipeline failed when the dependencies were installed (even though the build pipelines succeeded for some reason), so I needed to revert. Will take another look at it |
can you please re-open the PR once you have time? :) |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used this (https://storybook.js.org/addons/@storybook/addon-postcss) guide to enforce storybook to use postcss8, as required by PostCSS plugin tailwindcss.
Fixes #172