Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: postcss upgrade for storybook #173

Merged

Conversation

jelleag
Copy link
Contributor

@jelleag jelleag commented Nov 7, 2022

Used this (https://storybook.js.org/addons/@storybook/addon-postcss) guide to enforce storybook to use postcss8, as required by PostCSS plugin tailwindcss.
Fixes #172

@mitrotasios mitrotasios added the Hint: Dependency This issue concerns a dependency label Nov 7, 2022
@mitrotasios mitrotasios changed the title fix/postcss upgrade for storybook test: postcss upgrade for storybook Nov 8, 2022
@mitrotasios
Copy link
Member

Thanks for the PR!

@mitrotasios mitrotasios changed the title test: postcss upgrade for storybook build: postcss upgrade for storybook Nov 8, 2022
@mitrotasios mitrotasios merged commit 6691425 into tremorlabs:main Nov 8, 2022
mitrotasios added a commit that referenced this pull request Nov 8, 2022
mitrotasios added a commit that referenced this pull request Nov 8, 2022
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

🎉 This PR is included in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mitrotasios
Copy link
Member

The release ci pipeline failed when the dependencies were installed (even though the build pipelines succeeded for some reason), so I needed to revert. Will take another look at it

@mitrotasios
Copy link
Member

can you please re-open the PR once you have time? :)

@jelleag
Copy link
Contributor Author

jelleag commented Nov 9, 2022

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hint: Dependency This issue concerns a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook requires postcss 8
2 participants