Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Add type prop to Button component #205

Closed
cyruskorn opened this issue Nov 25, 2022 · 3 comments
Closed

Feature request - Add type prop to Button component #205

cyruskorn opened this issue Nov 25, 2022 · 3 comments
Labels
Priority: Medium This issue/feature is of medium priority Type: Enhancement Small enhancement to existing component or feature

Comments

@cyruskorn
Copy link

When using the Button component inside am HTML form, I can't set the button type to 'submit'. Giving access to the type prop of the button element through to Button component would make this possible with very little change.

Example use:

<form onSubmit={handleSubmit}>
  ...  
  <Button type='submit' text='Create item' />
</form>
@severinlandolt
Copy link
Member

Heya @cyruskorn, thank you for using our library. This feature makes a lot of sense, great that you reached out✨

@severinlandolt severinlandolt added enhancement Priority: Medium This issue/feature is of medium priority Type: Enhancement Small enhancement to existing component or feature and removed priority labels Nov 26, 2022
@severinlandolt
Copy link
Member

Related to #188

@mitrotasios
Copy link
Member

fixed in v1.3.0 #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue/feature is of medium priority Type: Enhancement Small enhancement to existing component or feature
Projects
None yet
Development

No branches or pull requests

3 participants