Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add option to control the duration or speed of the animation in Area and other charts #421

Closed
dthyresson opened this issue Apr 26, 2023 · 0 comments · Fixed by #430
Labels
Type: Feature New feature for existing component

Comments

@dthyresson
Copy link
Contributor

dthyresson commented Apr 26, 2023

When using the AreaChart, there is an option to turn on or off showing an animated rendering of the data points -- but it can feel a little slow, and give the impression that the performance is also sluggish.

I noticed that the charts wrap ReCharts and they have an option to set the animationDuration:

https://recharts.org/en-US/api/Area#animationDuration

This is a request to include the animationDuration option and pass it to all the chart/containers to be babel to control the speed of the animation.

In fact, exposing (but defaulting to sensible values):

image

  • animationBegin
  • animationEnd
  • animationEasing
  • animationDuration

might be useful.


Oh, I just realized that they get passed as ...other so perhaps this issue is more of a documentation issue to say these properties are available, too.

See: https://www.tremor.so/docs/components/area-chart

Although I do get a warning:

image


Update:

Actually other is passed to the div, not the ReChartsAreaChart or ResponsiveContainer

@mitrotasios mitrotasios added the Type: Feature New feature for existing component label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature for existing component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants