Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hides multiselect overflow-x scrollbar on Firefox #669

Merged
merged 1 commit into from Sep 12, 2023
Merged

fix: Hides multiselect overflow-x scrollbar on Firefox #669

merged 1 commit into from Sep 12, 2023

Conversation

joshmlamb
Copy link
Contributor

Description

I've added the CSS style scrollbar-width: none to the MultiSelect component to prevent the horizontal scrollbar from appearing when multiple items have been selected. A comparable style already was applied for Webkit browsers.

Related issue(s)

Fixes issue 668

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.

@joshmlamb joshmlamb changed the title Hides multiselect overflow-x scrollbar on Firefox fix: Hides multiselect overflow-x scrollbar on Firefox Sep 11, 2023
@severinlandolt
Copy link
Member

Oh, totally missed that! Thank you very much for this!

@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Sep 12, 2023
@joshmlamb
Copy link
Contributor Author

No worries, thank you for all the work you've put into this library!

@severinlandolt severinlandolt linked an issue Sep 12, 2023 that may be closed by this pull request
[Bug]: Misaligned multi select items on Firefox #668
Closed
@severinlandolt severinlandolt merged commit 64cdd1a into tremorlabs:main Sep 12, 2023
5 of 6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 3.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@severinlandolt severinlandolt severinlandolt approved these changes

Assignees
No one assigned
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Misaligned multi select items on Firefox
3 participants
@joshmlamb @severinlandolt @josh-enovate