Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: <Dialog /> component #830

Closed
christopherkindl opened this issue Nov 24, 2023 · 7 comments · Fixed by #902
Closed

[Feature]: <Dialog /> component #830

christopherkindl opened this issue Nov 24, 2023 · 7 comments · Fixed by #902
Assignees
Labels
Good first issue Beginner-friendly issue for first-time contributors Status: Help Wanted We need help with this issue

Comments

@christopherkindl
Copy link
Member

christopherkindl commented Nov 24, 2023

What problem does this feature solve?

Introduce <Dialog/> component as shown in plain code usign Headless UI in Tremor Blocks (First two examples).

Component should also use the transition used in those examples

Link to Headless UI documentation of <Dialog>

What does the proposed API look like?

<Dialog/> Props:
open?: boolean
onClose?: (false) => void
static: boolean (default: false)
unmount: boolean (default: true)

<DialogPanel/> Props:
open?: boolean

Way of building:

  <Dialog {...args}>
   <DialogPanel {...args}>
     [Content of Dialog]
   </DialogPanel>
  <Dialog>
@christopherkindl christopherkindl added Status: Help Wanted We need help with this issue Good first issue Beginner-friendly issue for first-time contributors labels Nov 24, 2023
@christopherkindl
Copy link
Member Author

Reference: #811

@Sanket-Arekar
Copy link

I would like to work on this issue. Can you Please assign me this issue?

@christopherkindl
Copy link
Member Author

sorry @Sanket-Arekar, somehow we did not see the comment. Now assigned! :)

@christopherkindl
Copy link
Member Author

@Sanket-Arekar Just to conform, do you want to work on that? :)

@iamtouha
Copy link
Contributor

@christopherkindl I would like to work on it.

@christopherkindl
Copy link
Member Author

@touha98 assigned! thank you :)

@iamtouha iamtouha mentioned this issue Jan 1, 2024
15 tasks
Copy link

🎉 This issue has been resolved in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Beginner-friendly issue for first-time contributors Status: Help Wanted We need help with this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants