Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support memoized config #5

Merged
merged 2 commits into from Nov 13, 2019
Merged

Support memoized config #5

merged 2 commits into from Nov 13, 2019

Conversation

cheton
Copy link
Member

@cheton cheton commented Nov 12, 2019

React context uses reference identity to determine when to re-render, this PR uses a memoized method to return the previously calculated result to avoid unintentional renders in consumers when a provider's parent re-renders.

@coveralls
Copy link

coveralls commented Nov 12, 2019

Pull Request Test Coverage Report for Build 32

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.118%

Totals Coverage Status
Change from base Build 27: 0.0%
Covered Lines: 16
Relevant Lines: 17

💛 - Coveralls

@cheton cheton merged commit 9e7a2d6 into master Nov 13, 2019
@cheton cheton deleted the memoized-config branch November 13, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants