Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scrollbar component #315

Merged
merged 16 commits into from Jun 21, 2021
Merged

feat: Scrollbar component #315

merged 16 commits into from Jun 21, 2021

Conversation

tinaClin
Copy link
Contributor

@tinaClin tinaClin commented Jun 3, 2021

No description provided.

@tinaClin tinaClin added the 🏗️ work in progress Work in progress label Jun 3, 2021
@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed ac468ba to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@cheton
Copy link
Member

cheton commented Jun 3, 2021 •
edited by tinaClin

The native scrollbar is rendered when toggling the dropdown menu at the first time.

image

@tinaClin fixed in c7820f3

@cheton cheton mentioned this pull request Jun 4, 2021
Closed
@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed 5120267 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed c7820f3 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed b687539 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed d1e8397 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed e63dab4 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@tinaClin tinaClin added 🎉 feature (enhancement) New feature or request 🔎 review required and removed 🏗️ work in progress Work in progress labels Jun 15, 2021
@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed 2cbc178 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed 42be733 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed b058d85 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@tinaClin tinaClin added the 🏗️ work in progress Work in progress label Jun 15, 2021
@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed f4bea0c to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed f4a0d09 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed 4e373f0 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

cheton
cheton requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@cheton cheton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments above

@trendmicro-frontend-bot
Copy link
Contributor

Successfully deployed 44ecb46 to https://trendmicro-frontend.github.io/styled-ui-demo/pr-315/

@tinaClin tinaClin merged commit 5bad171 into master Jun 21, 2021
@tinaClin tinaClin deleted the feat/scrollbar-component branch June 21, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheton cheton cheton approved these changes

@freewill0918 freewill0918 Awaiting requested review from freewill0918

@Ginioo Ginioo Awaiting requested review from Ginioo

@joshuatai joshuatai Awaiting requested review from joshuatai

@roth1002 roth1002 Awaiting requested review from roth1002

Assignees
No one assigned
Labels
🎉 feature (enhancement) New feature or request 🔎 review required 🏗️ work in progress Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tinaClin @trendmicro-frontend-bot @cheton