Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term dimension #2

Merged
merged 14 commits into from May 24, 2017
Merged

Term dimension #2

merged 14 commits into from May 24, 2017

Conversation

haroldangenent
Copy link
Member

Work in progress.

@haroldangenent haroldangenent self-assigned this May 22, 2017
@codecov
Copy link

codecov bot commented May 22, 2017

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #2   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity       24     30    +6     
=======================================
  Files             4      5    +1     
  Lines            74     99   +25     
=======================================
+ Hits             74     99   +25
Impacted Files Coverage Δ Complexity Δ
src/Dimension/Term.php 100% <100%> (ø) 6 <6> (?)
src/Hook/Posts.php 100% <100%> (ø) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c123f12...e824cd9. Read the comment docs.

@haroldangenent
Copy link
Member Author

@luukdv Ready for your review.

Copy link

@luukdv luukdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new readme it still says:

  • Currently only supports searching in postmeta
  • This package could get slow for complex meta searches
  • Currently this package only supports metadata as a search dimension

Besides that, looks good.

@haroldangenent haroldangenent merged commit 269bba4 into master May 24, 2017
@haroldangenent haroldangenent deleted the term branch May 24, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants