Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression test for focus state of Radio Input #322

Open
muratcorlu opened this issue Nov 17, 2022 · 1 comment
Open

Visual regression test for focus state of Radio Input #322

muratcorlu opened this issue Nov 17, 2022 · 1 comment
Assignees
Labels
bl-radio Radio Input Component

Comments

@muratcorlu
Copy link
Contributor

In the related PR I couldn't manage to run interaction tests on chromatic to get focus state screenshots. I contacted with Chromatic support and got an reply below:

Hey Murat!
Thanks for your patience - I wanted to provide you with a quick update regarding the issue you reported around interaction tests. We've identified that the issue is a bug, and our Engineering team is looking into what's causing it. I'll update you once a resolution has been reached - let me know if you have any questions in the meantime!
Regards,
Suki

Now we are waiting for a fix on Chromatic, then we'll need to check radio input focus state screenshots.

@muratcorlu muratcorlu added baklava-ds bl-radio Radio Input Component labels Nov 17, 2022
@muratcorlu muratcorlu self-assigned this Nov 17, 2022
@muratcorlu
Copy link
Contributor Author

We had an answer:

Hey Murat - thanks for your patience!
Our Engineers determined the reason your interaction tests are having issues showing is due to the Storybook version you're using. If you upgrade your Storybook version to 6.5.10 or later, you should see the interactions badge appear. Let me know if you have any questions or if you still experience issues after upgrading!
Regards,
Suki

I'll upgrade Storybook with this issue and check if it really fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bl-radio Radio Input Component
Projects
Status: No status
Development

No branches or pull requests

1 participant