Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: checkbox-group component #324

Merged
merged 9 commits into from
Dec 7, 2022
Merged

Conversation

olkeoguz
Copy link
Contributor

@olkeoguz olkeoguz commented Nov 23, 2022

Includes:

 <bl-checkbox-group id="sportSelection" label="Choose sports you like" name="sports" required value='["basketball","tennis"]'>
  <bl-checkbox value="football">Football</bl-checkbox>
  <bl-checkbox value="basketball">Basketball</bl-checkbox>
  <bl-checkbox value="tennis">Tennis</bl-checkbox>
</bl-checkbox-group>
<script>
  sportSelection.value; // ['basketball', 'tennis']
</script>

checkbox focus state screenshots will be added after #322 resolves.

Closes #290, closes #291.

Copy link
Contributor

@muratcorlu muratcorlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I just have a small remark. And let's also ask for a design review from @buseselvi 😊

@olkeoguz
Copy link
Contributor Author

olkeoguz commented Dec 1, 2022

After searching and discussing checkbox-group examples with @buseselvi, we decided to change the keyboard navigation. Pressing tab will always switch to the next element in the group rather than focusing outward.
Example : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/checkbox

But navigating with arrow keys will be the same as now.
I'll make these changes shortly if that's final @muratcorlu @buseselvi .

@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@muratcorlu muratcorlu merged commit cf7c787 into next Dec 7, 2022
@muratcorlu muratcorlu deleted the 291-checkbox-group-component branch December 7, 2022 08:40
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

🎉 This PR is included in version 2.0.0-beta.50 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using checkbox component in form Accessibility improvements on Checkbox component
3 participants