-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: checkbox-group component #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good! I just have a small remark. And let's also ask for a design review from @buseselvi 😊
After searching and discussing checkbox-group examples with @buseselvi, we decided to change the keyboard navigation. Pressing tab will always switch to the next element in the group rather than focusing outward. But navigating with arrow keys will be the same as now. |
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 2.0.0-beta.50 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Includes:
checkbox focus state screenshots will be added after #322 resolves.
Closes #290, closes #291.