-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast messages are hiding under dialog backdrop #617
Comments
This is a known limitation of using native Dialog element because Dialog element renders on top-layer, which you can not override it via z-index values. Technically Popover API is on the way which will fix this issue, but until that time, I think we may check for a workaround for this. Currently our dialog supports older browsers that don't support dialog element. We make that check automatically and use a polyfilled version instead with that small decision point: private get hasHtmlDialogSupport() {
return !!window.HTMLDialogElement;
} Maybe we can consider making this a property that you can manually set outside like: @property({ type: Boolean })
levelled = !window.HTMLDialogElement; So, whenever a popover opens within a browser that doesn't support Popover API, dialog that is already visible can be switched to
Please feel free to share your opinions. @Enes5519 PS: |
It is healthiest to do it this way, different ways are not ready yet, so we can pass prop in this way. |
🎉 This issue has been resolved in version 2.2.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue description
When we have a toast message to show while the dialog is open, the messages are hidden behind the dialog backdrop.
This is affecting the UX since the toasts like error or success messages are not enough clear to users.
Baklava Version
v2.2.0-beta.2
Low (slightly annoying)
The text was updated successfully, but these errors were encountered: