Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Select search should support international character set #830

Closed
ogunb opened this issue Apr 17, 2024 · 1 comment · Fixed by #857
Closed

[Feature Request]: Select search should support international character set #830

ogunb opened this issue Apr 17, 2024 · 1 comment · Fixed by #857
Labels
bl-select Select Component feature request Requesting a feature good first issue Good for newcomers released on @beta

Comments

@ogunb
Copy link
Contributor

ogunb commented Apr 17, 2024

Describe the problem or use case

Currenly user cannot search with Turkish letters:

Screenshot 2024-04-17 at 15 12 51 Screenshot 2024-04-17 at 15 13 02

Proposed solution

We could use localeCompare or toLocaleLowerCase with html lang tag.

Alternatives considered

No response

Additional technical context

I think we should also support not using those letters. Ex: İçecekler should be filtered with both İç and ıc. This would require more work than simply using locale functions though. Maybe we can look into some lightweight search libraries?
@ogunb ogunb added the bl-select Select Component label Apr 17, 2024
@erbilnas erbilnas added the feature request Requesting a feature label Apr 18, 2024
@AykutSarac AykutSarac added the good first issue Good for newcomers label Apr 18, 2024
@cenarturkmen cenarturkmen mentioned this issue Apr 24, 2024
Closed
@fatihkucuktry fatihkucuktry self-assigned this Apr 29, 2024
@fatihkucuktry fatihkucuktry mentioned this issue May 7, 2024
Merged
@fatihkucuktry fatihkucuktry removed their assignment May 17, 2024
buseselvi pushed a commit that referenced this issue Jun 13, 2024
@fatihkucuktry
feat(select): Improve select search international character support (#…
e9d7992 
…857)

Closes #830
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bl-select Select Component feature request Requesting a feature good first issue Good for newcomers released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(select): Improve select search international character support Trendyol/baklava
4 participants
@erbilnas @ogunb @AykutSarac @fatihkucuktry