Fix duplicate entries in TOC when using mixed headers #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for a bug that was introduced in #538, where duplicate entries could be added to the TOC when mixed headers were in use.
The issue was in the
_header_id_exists
, where I was attempting to check that a header ID already existed. The function only checked for the header ID in_count_from_header_id
, which contained the base ID but not the suffixed ones (eg:abc-1
).This PR has fixed this by also checking in the TOC itself for any header IDs that match.