Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better feedback for ember-exam@0.6 and ember-cli-qunit@4. #102

Closed
rwjblue opened this issue Aug 11, 2017 · 4 comments
Closed

Better feedback for ember-exam@0.6 and ember-cli-qunit@4. #102

rwjblue opened this issue Aug 11, 2017 · 4 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 11, 2017

This switch is pretty trolling for users. We made heavy note of the requirements to call start() in ember-cli release notes, but didn't mention anything about ember-exam. I think we can probably make it a bit nicer...

I'd suggest that we create a patch release of ember-exam@0.6.x that uses ember-cli-version-checker to detect if the host app is using ember-cli-qunit@4 and issue a loud warning (or even error) suggesting that they need to upgrade to ember-exam@0.7.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 11, 2017

@trentmwillis - Do you think ^ is a good plan?

@trentmwillis
Copy link
Member

This seems reasonable to me 👍

@trentmwillis
Copy link
Member

A little late, but I just published version 0.6.3 that addresses this.

@rwjblue
Copy link
Member Author

rwjblue commented Oct 5, 2017

Thank you. I completely forgot to do the work mentioned above. Sorry to let that fall back on you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants