-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add initial support to verify the password for the hacluster user (#164)
* Add initial support to verify the password for the hacluster user
- Loading branch information
Showing
7 changed files
with
190 additions
and
93 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| package gatherers | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/pkg/errors" | ||
| log "github.com/sirupsen/logrus" | ||
| crypt "github.com/tredoe/osutil/user/crypt" | ||
| sha512crypt "github.com/tredoe/osutil/user/crypt/sha512_crypt" | ||
| "github.com/trento-project/agent/pkg/factsengine/entities" | ||
| "github.com/trento-project/agent/pkg/utils" | ||
| ) | ||
|
|
||
| const ( | ||
| VerifyPasswordGathererName = "verify_password" | ||
| ) | ||
|
|
||
| // nolint:gochecknoglobals | ||
| var ( | ||
| checkableUsernames = []string{"hacluster"} | ||
| unsafePasswords = []string{"linux"} | ||
| ) | ||
|
|
||
| // nolint:gochecknoglobals | ||
| var ( | ||
| VerifyPasswordInvalidUsername = entities.FactGatheringError{ | ||
| Type: "verify-password-invalid-username", | ||
| Message: "requested user is not whitelisted for password check", | ||
| } | ||
|
|
||
| VerifyPasswordCryptError = entities.FactGatheringError{ | ||
| Type: "verify-password-crypt-error", | ||
| Message: "error while verifying the password for user", | ||
| } | ||
| ) | ||
|
|
||
| type VerifyPasswordGatherer struct { | ||
| executor utils.CommandExecutor | ||
| } | ||
|
|
||
| func NewDefaultPasswordGatherer() *VerifyPasswordGatherer { | ||
| return NewVerifyPasswordGatherer(utils.Executor{}) | ||
| } | ||
|
|
||
| func NewVerifyPasswordGatherer(executor utils.CommandExecutor) *VerifyPasswordGatherer { | ||
| return &VerifyPasswordGatherer{ | ||
| executor, | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| This gatherer expects only the username for which the password will be verified | ||
| */ | ||
| func (g *VerifyPasswordGatherer) Gather(factsRequests []entities.FactRequest) ([]entities.Fact, error) { | ||
| facts := []entities.Fact{} | ||
| log.Infof("Starting password verifying facts gathering process") | ||
|
|
||
| for _, factReq := range factsRequests { | ||
| if !utils.Contains(checkableUsernames, factReq.Argument) { | ||
| gatheringError := VerifyPasswordInvalidUsername.Wrap(factReq.Argument) | ||
| fact := entities.NewFactGatheredWithError(factReq, gatheringError) | ||
| facts = append(facts, fact) | ||
| continue | ||
| } | ||
| username := factReq.Argument | ||
|
|
||
| salt, hash, err := g.getSalt(username) | ||
| if err != nil { | ||
| log.Error(err) | ||
| } | ||
| log.Debugf("Obtained salt using user %s: %s", username, salt) | ||
|
|
||
| crypter := sha512crypt.New() | ||
| isPasswordWeak := false | ||
| var gatheringError *entities.FactGatheringError = nil | ||
| for _, password := range unsafePasswords { | ||
| passwordBytes := []byte(password) | ||
|
|
||
| matchErr := crypter.Verify(hash, passwordBytes) | ||
| if matchErr == nil { | ||
| isPasswordWeak = true | ||
| break | ||
| } | ||
| if !errors.Is(matchErr, crypt.ErrKeyMismatch) { | ||
| gatheringError = VerifyPasswordCryptError.Wrap(username) | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if gatheringError != nil { | ||
| fact := entities.NewFactGatheredWithError(factReq, gatheringError) | ||
| facts = append(facts, fact) | ||
| continue | ||
| } | ||
|
|
||
| fact := entities.NewFactGatheredWithRequest(factReq, | ||
| &entities.FactValueBool{Value: isPasswordWeak}) | ||
| facts = append(facts, fact) | ||
| } | ||
|
|
||
| log.Infof("Requested password verifying facts gathered") | ||
| return facts, nil | ||
| } | ||
|
|
||
| func (g *VerifyPasswordGatherer) getSalt(user string) ([]byte, string, error) { | ||
| shadow, err := g.executor.Exec("getent", "shadow", user) | ||
| if err != nil { | ||
| return nil, "", errors.Wrap(err, "Error getting salt") | ||
| } | ||
| salt := strings.Split(string(shadow), "$")[2] | ||
| hash := strings.Split(string(shadow), ":")[1] | ||
|
|
||
| return []byte(fmt.Sprintf("$6$%s", salt)), hash, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters