Remove the flavor field and add the installation source #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
reviewed
Jul 28, 2022
arbulu89
changed the title
|
LGTM |
CDimonaco
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flavorfield is not used in the Agent since the web code was extracted, and there is not any "premium" capability.For that reason it is removed.
And in order to have more information in our telemetry system, a new "installation source" metric is added, so we know how the agent was installed. The options are:
Community: The agent was build after getting it from Github (whether downloading the code and building or getting the artficats)Suse: The agent is installed through a RPM package coming from OBS/IBS. There is not any distinctions between the source repository.