This repository has been archived by the owner on May 30, 2022. It is now read-only.
Ansible runner improvements - Run meta playbook #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
fabriziosestito,
rtorrero,
stefanotorresi and
aleksei-burlakov
arbulu89
force-pushed
the
feature/ansible-runner-improvements
branch
from
8bb3c05
to
304b93c
Compare
arbulu89
force-pushed
the
feature/ansible-runner-improvements
branch
from
304b93c
to
81ec208
Compare
rtorrero
reviewed
Jul 28, 2021
runner/runner_test.go
Outdated
| a, err := NewAnsibleMetaRunner(cfg) | ||
|
|
||
| expectedMetaRunner := &AnsibleRunner{ | ||
| Playbook: "../test/ansible_test/ansible/meta.yml", |
There was a problem hiding this comment.
It may be better to try to declare constants on top of the file with the Ansible playbooks directories and file names to avoid repeating them several times. No big deal though.
There was a problem hiding this comment.
Improved in: 0b54d0c
rtorrero
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements on the Ansible runner component.
Major changes:
AnsibleRunneris used, to provide more flexibility, as we need customization in each of the ansible calls. TheRunPlaybookfunction covers more use cases (like running without any inventory)The playbook names might change after we have something established about the whole Ansible playbooks structure