This repository has been archived by the owner on May 30, 2022. It is now read-only.
Remove landscapes environments #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
rtorrero,
stefanotorresi,
aleksei-burlakov and
arbulu89
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
…ate tests Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
Co-authored-by: Rubén Torrero Marijnissen <rtorreromarijnissen@suse.com>
fabriziosestito
force-pushed
the
remove_landscapes_environments
branch
from
e37827e
to
c816bae
Compare
arbulu89
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
@fabriziosestito @rtorrero
Looks great! A nice cleanup hehe
| return nil, errors.Wrap(err, "could not get the filters") | ||
| } | ||
| for _, host := range hostList { | ||
| for _, s := range strings.Split(host.TrentoMeta()["trento-sap-systems"], ",") { |
There was a problem hiding this comment.
I guess there is not any function to remove duplicated values, right?
There was a problem hiding this comment.
nope, for what i know this is the idiomatic way to create sets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes landscapes and environments from internal packages, html templates and web handlers.
Some refactor was required for the SAPSystemHandler detail view which was based on env and landscapes.