Cluster check result modal #189
Cluster check result modal #189
Conversation
49bbfa5
to
afe68bf
Compare
Issues and comments addressed. Besides this, I have implemented the notifications to the users for the scenario where some node is not reachable by ansible. It looks like this: @fabriziosestito @rtorrero Could you have a look? |
aa2090f
to
ce2ae8f
Compare
@arbulu89 Some small UX refinements suggestions here. I think the list of checks is already big, so I suggest we have sorting and filtering options on the modal too, so the user can find the failed test easier than scrolling it completely. Maybe a summary on the header for each node could make sense too. Another point is that, on the first video, I might have spotted a bug. The main counters on the header of the main screen presents 0 success, while when checking the results we can see we have successes there. Let me know if a new issue is needed for that. |
Thank you for checking it out. The filtering is something we have in mind, but It won't come in this PR. It requires some important frontend changes that are not simple to execute. We will work on that in future iterations. |
059df14
to
3f4b038
Compare
3f4b038
to
9a26475
Compare
Implementation of the cluster checks result modal. It provides the ansible runner checks result in the cluster page (only the latest execution, we don't have an historical view yet), showing all the checks results by host.
It consumes the ARA record
trento-results
from ARA, and in combination with metadata information, it displays the modal.I have done some changes in the ARA records json structures to be more meaningful. (08e3f5d)
Besides that, some new models for the checks are added, to handle this new Json structure.
Disclaimer: The results are changed once the runner is executed, so even though we change the selected checks from the settings modal, the update of the results is not immediate.
Here a short demo: