Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Cluster check result modal #189

Merged
merged 12 commits into from Sep 1, 2021

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Aug 4, 2021

Implementation of the cluster checks result modal. It provides the ansible runner checks result in the cluster page (only the latest execution, we don't have an historical view yet), showing all the checks results by host.

It consumes the ARA record trento-results from ARA, and in combination with metadata information, it displays the modal.

I have done some changes in the ARA records json structures to be more meaningful. (08e3f5d)

Besides that, some new models for the checks are added, to handle this new Json structure.

Disclaimer: The results are changed once the runner is executed, so even though we change the selected checks from the settings modal, the update of the results is not immediate.

Here a short demo:
checks_result

web/services/checks.go Outdated Show resolved Hide resolved
web/clusters.go Outdated Show resolved Hide resolved
@arbulu89
Copy link
Contributor Author

arbulu89 commented Aug 31, 2021

Issues and comments addressed. Besides this, I have implemented the notifications to the users for the scenario where some node is not reachable by ansible. It looks like this:

image

@fabriziosestito @rtorrero Could you have a look?

@diegoakechi
Copy link
Contributor

@arbulu89 Some small UX refinements suggestions here.

I think the list of checks is already big, so I suggest we have sorting and filtering options on the modal too, so the user can find the failed test easier than scrolling it completely. Maybe a summary on the header for each node could make sense too.

Another point is that, on the first video, I might have spotted a bug. The main counters on the header of the main screen presents 0 success, while when checking the results we can see we have successes there. Let me know if a new issue is needed for that.

@arbulu89
Copy link
Contributor Author

@arbulu89 Some small UX refinements suggestions here.

I think the list of checks is already big, so I suggest we have sorting and filtering options on the modal too, so the user can find the failed test easier than scrolling it completely. Maybe a summary on the header for each node could make sense too.

Another point is that, on the first video, I might have spotted a bug. The main counters on the header of the main screen presents 0 success, while when checking the results we can see we have successes there. Let me know if a new issue is needed for that.

Thank you for checking it out.

The filtering is something we have in mind, but It won't come in this PR. It requires some important frontend changes that are not simple to execute. We will work on that in future iterations.
About the main page and the modal, the synchronization of them is not implemented either, it will come in future PRs. In any case, the page summary window doesn't show the check results data, it shows the nodes state summary, which is the number of failed/working nodes in this cluster

@fabriziosestito
Copy link
Member

Thanks!

@arbulu89 arbulu89 merged commit f1f6f8d into trento-project:runner Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants