Add cluster connection settings user input in cluster modal #217
Conversation
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
aleksei-burlakov
|
@fabriziosestito @rtorrero @aleksei-burlakov @dottorblaster @stefanotorresi |
| func azureMeta(userIndex int) map[string]interface{} { | ||
| return map[string]interface{}{ | ||
| "provider": cloud.Azure, | ||
| "metadata": &cloud.AzureMetadata{ | ||
| Compute: cloud.Compute{ | ||
| OsProfile: cloud.OsProfile{ | ||
| AdminUserName: fmt.Sprintf("defuser%d", userIndex), | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
Very declarative, I like it!
There was a problem hiding this comment.
@arbulu89 I tried to run the PR on gollum, the default user is an empty column in the modal.
Is this desired or we want to show "root" in the case we are not running on Azure?
P.S: Please don't laugh at my cluster petname
This value is coming from the cloud metadata, so in libvirt we don't have it. Behind the scenes, if it is not being shown there |
Oh ok, yes I would go with the hardcoded one in case we are not on azure, just to be consistent with the UI |
|
arbulu89
force-pushed
the
feature/cluster-connection-settings
branch
from
874c1cd
to
f824d65
Compare
Implement the option to customize the ansible ssh connection settings, specifically the user that is used during the ssh connections.
This is done through the cluster settings modal.
It follows the next logic:
trento/v0/clusters/mycluster/user_settings/connection/as mapansible_uservalueDemo:
Follow up issues:
#218
#219