Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Rename sidebar entries to Pacemaker Clusters and SAP Systems #283

Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 30, 2021

Rename sidebar entries:

  • Clusters -> Pacemaker Clusters
  • Systems -> SAP Systems

Besides the sidebar, I have renamed the Cluster pages to add the Pacemaker prefix (the SAP systems already had the SAP prefix).

Question: Should be rename the hosts page table columns name too? Clusters to P. Clusters and Systems to SAP Systems maybe

image
image
image
image

@arbulu89 arbulu89 force-pushed the feature/rename-sidebar-entries branch 2 times, most recently from c22927a to 8eb5e67 Compare September 30, 2021 09:19
@arbulu89 arbulu89 force-pushed the feature/rename-sidebar-entries branch from 8eb5e67 to f8c4000 Compare September 30, 2021 09:20
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd also change scope.md as there are a few mentions to Clusters and Systems in there

@arbulu89
Copy link
Contributor Author

arbulu89 commented Sep 30, 2021

Looks good to me, but I'd also change scope.md as there are a few mentions to Clusters and Systems in there

I can change the names, but now I see this scope.md file, it has so many outdated things, that it requires a complete re-writing

PD: scope.md main changes done: e91f8f2

Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanotorresi stefanotorresi merged commit 9b7c8e1 into trento-project:main Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants