Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Fix runner container image #287

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

stefanotorresi
Copy link
Member

@stefanotorresi stefanotorresi commented Sep 30, 2021

This PR introduces the usage of multi-target Dockerfile builds, to produce to separate containers for the web and the runner components.

The problem we originally had is that the image didn't include ssh, so the runner woudn't work properly, causing all the checks to be reported as passing, while actually they would not be executed at all.

It also does the following:

  • some other misc renaming in the CI jobs
  • updates the Helm charts accordingly
  • the Helm charts now will install the rolling tag by default
  • appVersion is gone, the only place where we need to update the pinned version are the bash installers.

@stefanotorresi stefanotorresi force-pushed the fix-runner-image branch 3 times, most recently from d0405e4 to 6a8da97 Compare September 30, 2021 16:46
@stefanotorresi stefanotorresi marked this pull request as ready for review September 30, 2021 16:49
Comment on lines +9 to +10
pullPolicy: Always
tag: "rolling"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we avoid this? ._.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, what do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @dottorblaster means to ask if we could avoid the pullPolicy: Always? If so, I understood this is a side effect of using tag: rolling (to ensure the image gets pulled even when the tag is the same).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, for now I think it's useful to have an Always pullPolicy and point to the rolling tag but keep in mind that this will end up in the hands of customers, and I don't know if this is the best strategy to handle the distribution of the containers 🙂

@rtorrero anticipated my answer, Github was down while I was posting this comment :D

Copy link
Member Author

@stefanotorresi stefanotorresi Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but I don't see anything particularly problematic about Always: the container engine will not waste bandwidth if the image hash is identical, but by using Always we at least enforce to check if there is a new image available, otherwise it will keep using whatever it has already in cache under that repo:tag.
TL;DR: I'm not aware of good reasons not to use it, even for non-rolling tags, and it will surely avoid upgrading headaches.

@stefanotorresi stefanotorresi added documentation Improvements or additions to documentation bug Something isn't working and removed documentation Improvements or additions to documentation labels Oct 1, 2021
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanotorresi stefanotorresi merged commit bb3932e into trento-project:main Oct 1, 2021
@stefanotorresi stefanotorresi deleted the fix-runner-image branch October 1, 2021 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

4 participants