This repository has been archived by the owner on May 30, 2022. It is now read-only.
Avoid using "rolling" as version and use the previous version instead #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanotorresi
approved these changes
Oct 5, 2021
rtorrero
force-pushed
the
fix-wrong-rolling-version
branch
from
17685df
to
8a1ae0d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem mentioned in #293 that causes the spec file to be versioned with the 1.38.1 version.
It adds a condition to the
get_version_from_git.shscript to avoid appendingrollingas prefix to the version when the last git tag isrolling. It tries to pick up the previous tagged version instead.