Refactor version checks

[aleksei-burlakov]

Use ansible.builtin.package_facts instead of shell.

I think the PR is self explaining. There is still a minor improvement that should be done:
There is a repeating block

- name: Gather the package facts
  ansible.builtin.package_facts:
    manager: auto

in the checks 2.2.3 ... 2.2.7. However if I put this block in the runner/ansible/roles/load_facts/tasks/main.yml like here https://github.com/trento-project/trento/pull/344/files#diff-1c2ed1309d3811de445241b2d87823d1e5b0df3e383c4d6a4f7a39996dacf107, the trento-runner container simply fails to start.

@arbulu89 @brett060102 what do you think about this?

[brett060102]

Code does work, but would suggest following change:
1: do package_facts one in load facts:

index 581d485..569e00d 100644
--- a/runner/ansible/roles/checks/2.2.3/tasks/main.yml
+++ b/runner/ansible/roles/checks/2.2.3/tasks/main.yml
@@ -1,11 +1,7 @@
 ---
 
-- name: Gather the package facts
-  ansible.builtin.package_facts:
-    manager: auto
-
 - block:
-    - name: Post results
+    - name: "{{ name }} Post results"
       import_role:
         name: post-results
   vars:
diff --git a/runner/ansible/roles/checks/2.2.4/tasks/main.yml b/runner/ansible/roles/checks/2.2.4/tasks/main.yml
index a0695c2..cf0e702 100644

[arbulu89]

@aleksei-burlakov
Nice! It looks simply much better.
We need to change the comparisons to >= as the expected value is accepted as well.

Besides that, I'm a bit concerned about the repeated usage of the package loading task. If the execution of each task is executed completely, and it takes a lot of time, I would vote to moving it to some generic role.

[aleksei-burlakov]

@arbulu89 @brett060102 could you please approve the PR?

[aleksei-burlakov]

The python-rpm has other versioning that the suse rpm rpm. It's not 4.14.02 but 0.0.2

[arbulu89]

mmm, the version 0.0.2 looks a like a placeholder. Maybe we should install using apt-get install python3-rpm which would bring the a more maintained version.
Anyway, if this works it is fine for me

[brett060102]

LGTM and tests cleanly for me.

[arbulu89]

Thanks @aleksei-burlakov ,
It looks good to me. I have some doubts with the 0.0.2 rpm version, but if it works I guess we can move forwatd

[rtorrero]

I like how much simpler this looks now, gj!