-
Notifications
You must be signed in to change notification settings - Fork 25
Make all discoveries able to publish data to the Collector #371
Make all discoveries able to publish data to the Collector #371
Conversation
21c92db
to
fab717b
Compare
fab717b
to
7208e26
Compare
…o consul) so all the discoveries can use it
7208e26
to
097b0c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
As a follow up work, we would need to unify the json annotations to use always the same format, and not mix, camel case, underscores, capital letters, etc
I know that you just inherited this, but we should do it at some point in the future
PD: I see a lot of fixtures. We had some of them before already. Please, have a look if any of them got deprecated and we should remove the file
097b0c9
to
e03748b
Compare
Thanks @arbulu89 for the review and feedback.
I think I didn't see the fixtures you're referring to 😅 . Where should I look for those? |
There are some files in the Forget about it in this PR at least. We will do some cleanup at some point! |
Previously we made the #361 which makes the cluster discovery able to publish data to the collector.
This PR is following up that path and it makes all the discovery loops able to publish data to the collector.
I added some tests as well, except for the sapsystem discovery, which is not really handy to test.