This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add default collector port configuration #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Oct 26, 2021
There was a problem hiding this comment.
Hey @fabriziosestito ,
Now that I see this, I have some doubts with the cobra/viper relationship.
I see that, we use the viper.GetString("host") option to retrieve the value, and not the value it self attached in StringVar.
Now, we have 2 flags attached to -p flag. How does this work?
Are cobra and viper intelligent enough to know to get the values from the short flags?
What happens when you use the -p flag?
cmd/web/web.go
Outdated
| @@ -49,6 +49,7 @@ func NewWebCmd() *cobra.Command { | |||
| serveCmd.Flags().StringVar(&dbPassword, "db-password", "postgres", "The database password") | |||
| serveCmd.Flags().StringVar(&dbName, "db-name", "trento", "The database name that the application will use") | |||
|
|
|||
| serveCmd.Flags().IntVarP(&port, "collector-port", "p", 8081, "The port for the data collector service to listen on") | |||
There was a problem hiding this comment.
I know that this port actually is not used, but it wouldn't be better, for sake of being easier to understand, to have other variable? Like collectorPort.
And in fact, would are attached to the short flag p. Doesn't this create a collision?
fabriziosestito
force-pushed
the
default_collector_port
branch
from
690e6b5
to
7ee09fc
Compare
fabriziosestito
force-pushed
the
default_collector_port
branch
from
7ee09fc
to
01e2816
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default collector port configuration in the web side and changes the port number to 8081