added DATA_COLLECTOR_ENABLED=true to the CI

[nelsonkopliku]

This will enable data collection in DEMO

[arbulu89]

Just playing as devil's advocate, does something prevents us to completely enable the data collection?
I mean, is there any scenario where we don't want to have it? Or is it just play safe?

[rtorrero]

Wasn't aware of this way of setting an env-var for all the systemd units. Nice :-)

[rtorrero]

Just playing as devil's advocate, does something prevents us to completely enable the data collection? I mean, is there any scenario where we don't want to have it? Or is it just play safe?

I wouldn't enable them by default; once we are able to remove consul we can also get rid of this variable ((unless I misunderstood something)

[nelsonkopliku]

Just playing as devil's advocate, does something prevents us to completely enable the data collection?
I mean, is there any scenario where we don't want to have it? Or is it just play safe?

@arbulu89 Just playing it safe. It is also a way to experiment on feature flags on demo. Still in the process of learning

Wasn't aware of this way of setting an env-var for all the systemd units. Nice :-)

@rtorrero tanks!
@fabriziosestito and I didn't know either. But google does 😂

[fabriziosestito]

@rtorrero @arbulu89 it is a mix of both reasons, we want to play safe till we don't test it in our environment and we might ship them for good when we have enough confidence on how they work/system impact.

AKA that flag will be gone from every (or some) discovery loop once we decide to switch completely (or partially) to the new system.

[arbulu89]

@rtorrero @arbulu89 it is a mix of both reasons, we want to play safe till we don't test it in our environment and we might ship them for good when we have enough confidence on how they work/system impact.

AKA that flag will be gone from every (or some) discovery loop once we decide to switch completely (or partially) to the new system.

Ok, playing safe, but not in the demo environment hehe
That's a bit contradictory to me, as I would say that the demo environment is a place where we should play safe if there is no 100% confidence in the current implementation. But well, go ahead. If you have all of these temporary pieces of code in mind to be deleted later.