Identify trento installation #472
Conversation
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
2 times, most recently
from
e32cdc4
to
15bf8bb
Compare
|
There are many Trento, but which one is the Trento ™️? |
nelsonkopliku
requested review from
fabriziosestito,
stefanotorresi,
dottorblaster,
rtorrero and
arbulu89
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
from
15bf8bb
to
dc6769e
Compare
There was a problem hiding this comment.
@nelsonkopliku It looks good. Added some comments and questions before approving hehe
There was a problem hiding this comment.
This looks good to me, but I have some doubts on the naming of the entity/service.
Trento sounds a bit generic and since @dottorblaster is working on something like SystemSettings maybe they could be the same Service/share the same entity?
@fabriziosestito That's correct what you say, there's a relation with what @dottorblaster is on. |
|
Makes me laugh, I was just thinking "how do I manage the ID column", then I saw that basically the Trento ™️ entity overlaps with my SystemSettings work. :D Do you wanna name that so and I rebase against your work @nelsonkopliku? |
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
from
dc6769e
to
64c6482
Compare
@dottorblaster sure thing! So my |
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
3 times, most recently
from
21675cd
to
53a941d
Compare
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
2 times, most recently
from
e45eb24
to
4eaaa1d
Compare
| settigsService.On("InitializeIdentifier").Return(uuid.MustParse("59fd8017-b7fd-477b-9ebe-b658c558f3e9"), nil) | ||
|
|
||
| return settigsService | ||
| } |
There was a problem hiding this comment.
@dottorblaster take a look, we'll need the same approach for the premium/telemetry middleware, by just adding a On clause to the mock
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
2 times, most recently
from
5aca739
to
7829bca
Compare
nelsonkopliku
force-pushed
the
identify_trento_installation
branch
from
7829bca
to
772664e
Compare
This PR introduces Trento installation identification mechanism
This becomes needed when publishing telemetry data to the telemetry service.
A random UUID is generated once at trento startup and it gets stored in the database for future usage in the system
That value would stay unchanged until the database and specifically that simple information, for any reason, gets cleaned up.
In that case we interpreted the scenario as a new installation.