This repository has been archived by the owner on May 30, 2022. It is now read-only.
Switch to projected sapsystems list #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
force-pushed
the
switch_to_projected_sapsystems_list
branch
2 times, most recently
from
60868fa
to
52a69a7
Compare
fabriziosestito
force-pushed
the
switch_to_projected_sapsystems_list
branch
from
c8dbef0
to
fe5b467
Compare
fabriziosestito
requested review from
dottorblaster,
nelsonkopliku and
stefanotorresi
dottorblaster
approved these changes
Dec 7, 2021
Comment on lines
+57
to
+62
| err := s.db. | ||
| Model(&entities.SAPSystemInstance{}). | ||
| Group("type"). | ||
| Having("type = ?", models.SAPSystemTypeApplication). | ||
| Count(&count). | ||
| Error |
nelsonkopliku
approved these changes
Dec 7, 2021
| @@ -164,7 +164,8 @@ func (s *clustersService) GetAllTags() ([]string, error) { | |||
| var tags []string | |||
|
|
|||
| err := s.db. | |||
| Model(&models.Tag{ResourceType: models.TagClusterResourceType}). | |||
| Model(&models.Tag{}). | |||
There was a problem hiding this comment.
For me to understand: is the behaviour the same as before with
Model(&models.Tag{ResourceType: models.TagClusterResourceType})?
There was a problem hiding this comment.
Something slipped in the various refactors, this is not working since Model only infers the type from the passed struct and ignores conditions. Fixes: #544
This was referenced Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to projected sapsystems list and fixes some quirks in the tags methods of clusters and hosts handlers (#
The tag api will use the new service in a follow up PR
Fixes #544, #545