Hosts UI revamp #552
Hosts UI revamp #552
Conversation
dottorblaster
force-pushed
the
hosts-ui-revamp
branch
2 times, most recently
from
b7d115c
to
6148b05
Compare
dottorblaster
requested review from
fabriziosestito,
nelsonkopliku and
stefanotorresi
web/models/host.go
Outdated
|
|
||
| type AzureCloudData struct { | ||
| VMName string `json:"vmname"` | ||
| ResourceGroup string `json:"resourceGroup"` |
There was a problem hiding this comment.
Aha! camelCase vs snake_case strikes again 
Unfortunately we are not being consistent in the way we want json to look like.
And I am part of the problem, too 馃槥, for instance in #546 I have used snake_case
We did it differently throughout the code and I think that at a certain point we should sit, make an agreement on the style, and then commit to refactor all the codebase accordingly, which might not be trivial.
For reference: we have also an open issue for this #385
I don't think it is the right time to tackle such a refactor, though we can find an agreement for the immediate future.
I'd like to keep #546 consistent with this PR and since I don't have strong preferences, I can fix it to make camelCase compliant. Would that be ok?
Then we can have a wider discussion and consider refactoring as well.
There was a problem hiding this comment.
@nelsonkopliku @dottorblaster in the entities/models i personally have used snake case everywhere, maybe we can keep this consistent at least for this layer and think about a clean-up later. wdyt?
There was a problem hiding this comment.
Ok, whatever it works better. Anyway we'd need to find an agreement on such things. Just not now 馃槃
There was a problem hiding this comment.
i like better the camel case honestly, we can refactor all at once laterz
There was a problem hiding this comment.
A bit late but ok for me.
An image is worth a thousand words:
Also, bonus point 馃専 鉃★笍 this PR makes the single host UI page Consul-free.