Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

"About premium" improvements #591

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

rtorrero
Copy link
Contributor

This PR addresses the new template changes requested in issue #582. The other changes should have been addressed in PR #586

This is how it looks now for both cases when no subscriptions are found and when there are e.g. 2 subscriptions found.
2-found
none-found

In both cases there is now a tooltip
tooltip

stating the number of subscriptions found. This is not exactly what the issue wanted but what I understood was the intention from the conversation we had yesterday.

Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the changes @nelsonkopliku is doing, I don't know if we will still have the current IsPremium function. Most probably, we will need to change the backend handler to use the new service, but I'm not sure.

In the other hand, the fronted looks good, but didn't we agree to have an info icon for the tooltip?

@rtorrero
Copy link
Contributor Author

With the changes @nelsonkopliku is doing, I don't know if we will still have the current IsPremium function. Most probably, we will need to change the backend handler to use the new service, but I'm not sure.

In the other hand, the fronted looks good, but didn't we agree to have an info icon for the tooltip?

Yes, the info icon is probably a good hint for the user that there is a tooltip there, adding it now. About the IsPremium, I'll have a quick chat with @nelsonkopliku Thanks!

@rtorrero rtorrero merged commit 9b076a5 into trento-project:main Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants