Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Point the telemetry service to telemetry.trento.suse.com #640

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

dottorblaster
Copy link
Contributor

As above 😅

@dottorblaster dottorblaster self-assigned this Dec 21, 2021
@@ -40,7 +40,7 @@ func (tp *TelemetryPublisher) Publish(telemetryName string, installationID uuid.
return nil
}

var apiHost = "https://telemetry.trento-project.io" // this service still does not exist
var apiHost = "https://telemetry.trento.suse.com" // this service still does not exist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @dottorblaster ,
I would remove the comment besides the new domain, as now it will exists hehe

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, now I notice, apiHost looks a quite inaccurate name for this, doesn't it? XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad naming here is my fault 😅
Feel free to change or not to something like telemetryApiHost telemetryEndpoint or whatever makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment removed, thanks for that! apiHost was quite clear to me but feel free to suggest something else, I think this line is going to be edited a lot to allow configuration via build flags in the future so... 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 for renaming. I suggest telemetryServiceUrl.

web/telemetry/publisher.go Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants