This repository has been archived by the owner on May 30, 2022. It is now read-only.
Remove skipping for an older event #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
dottorblaster,
rtorrero,
nelsonkopliku and
arbulu89
arbulu89
approved these changes
Jan 26, 2022
@arbulu89 l will hold the merge till confirmation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To deal with the unlikely scenario of an agent sending multiple events of the same type at the same time, a skip event condition was introduced.
This wasn't working properly since it did not consider that an agent can send different types of events almost in parallel and it was just causing side effects when loading fixtures with
photofinish.Closes: #742