This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add load config to install-server script #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
requested review from
dottorblaster,
rtorrero,
stefanotorresi,
nelsonkopliku and
arbulu89
nelsonkopliku
approved these changes
Jan 27, 2022
There was a problem hiding this comment.
LGTM
If I understand correctly in /etc/trento/installer.conf we can override any of the env variable for the installer script.
For instance the place where to get the helm chart from, thus allowing the premium installation to get helm charts from a non IBS place.
👍
arbulu89
approved these changes
Jan 27, 2022
@arbulu89 sent you an example on slack |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to configure the server installer script by a
/etc/trento/installer.conffile, by overriding env variables.This is needed in order change the behavior of the installer script in different trento flavors (e.g. Premium)