Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

Reorganize sapsystem data #75

Merged

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 3, 2021

Some improvements in the sapsystem internal code.

Disclaimer: This is the 1st change on a queue of improvements on the road for the SAP discovery mechanism. I preferred to make the PR small to make the review easier

The major change is the modification of the SAPSystem struct, which now stores multiple SAPInstances. With this, I have changed a bit the html templates to show properly multiple instances per host.

Pending things that will come later

  • Get and store data in the KV storage of the DEFAULT.PFL for each SAP system. This will be needed to associate the SAP Application with the database
  • Implement the method to get the SAP system identifier (some discussions in progress in internal confluence)
  • Move sapsystems data in the KV storage. Now it is stored in trento/v0/hosts/$host1/sapsystems. To make it more accessible and less dependant on hosts it will be moved to trento/v0/sapsystems
  • Update the SAPSystem struct to store a list of host for the instances. This will be done to make easier the visualition, and know exactly in which node is running each SAP instance (SAP instance stores the virtual hostname, which is not good for this purpose)
  • And more changes in the frontend that I won't cover here now...

@arbulu89 arbulu89 marked this pull request as ready for review June 3, 2021 11:56
@arbulu89
Copy link
Contributor Author

@stefanotorresi @rtorrero @fabriziosestito Code rebased from the main branch. Now, we should be able to review and merge

@stefanotorresi
Copy link
Member

Way to go, Xabi!

@stefanotorresi stefanotorresi merged commit e64442a into trento-project:main Jun 16, 2021
stefanotorresi added a commit to stefanotorresi/trento that referenced this pull request Jun 16, 2021
@stefanotorresi stefanotorresi mentioned this pull request Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants