This repository has been archived by the owner on May 30, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements in the
sapsystem
internal code.Disclaimer: This is the 1st change on a queue of improvements on the road for the SAP discovery mechanism. I preferred to make the PR small to make the review easier
The major change is the modification of the
SAPSystem
struct, which now stores multipleSAPInstance
s. With this, I have changed a bit the html templates to show properly multiple instances per host.Pending things that will come later
DEFAULT.PFL
for each SAP system. This will be needed to associate the SAP Application with the databasesapsystems
data in the KV storage. Now it is stored intrento/v0/hosts/$host1/sapsystems
. To make it more accessible and less dependant on hosts it will be moved totrento/v0/sapsystems
SAPSystem
struct to store a list of host for the instances. This will be done to make easier the visualition, and know exactly in which node is running each SAP instance (SAP instance stores the virtual hostname, which is not good for this purpose)